Skip to content

Fix SPA stats duplication and add non-current week display#18

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
spa-stats-and-display-fix-3242554097557872919
Draft

Fix SPA stats duplication and add non-current week display#18
google-labs-jules[bot] wants to merge 1 commit intomainfrom
spa-stats-and-display-fix-3242554097557872919

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses two main issues in the SPA version of the course scheduler:

  1. Statistics Inflation: Previously, the solver simply summed up credits and hours for all scheduled items. If a course was split into meta-groups (e.g. same course, different teachers), it could be counted multiple times. The fix introduces a Set to deduplicate these statistics based on the course name.
  2. Missing Courses in Display: Courses that are not active in the currently selected week were invisible, confusing users. A new "Show All Weeks" checkbox was added. When enabled, it searches for sessions or bitmap occupancy in any week for a given slot. If found, the course is displayed with a gray style to indicate it is not currently active but exists in the schedule.

Additionally, a user-requested feature to warn about duplicate course names when adding groups was implemented.


PR created automatically by Jules for task 3242554097557872919 started by @OsakaLOOP

1. Modified `dist/static/js/solver.js` to deduplicate course statistics (credits/hours) by course name.
2. Modified `dist/index.html` and `dist/static/js/app.js` to add a "Show All Weeks" checkbox.
3. Implemented logic to display courses from non-current weeks in gray.
4. Added duplicate course warning when creating groups.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants